feature: non-consensus based block-access-list(EIP-7928)#3413
Merged
zzzckck merged 7 commits intobnb-chain:feature_bal7928from Dec 16, 2025
Merged
Conversation
fynnss
force-pushed
the
feature/bal_with_post_state_no_consensus
branch
6 times, most recently
from
4a8d81c to
094fe8c
Compare
fynnss
changed the title
fynnss
changed the title
fynnss
force-pushed
the
feature/bal_with_post_state_no_consensus
branch
3 times, most recently
from
dae1cda to
0201f0e
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements batch update functionality for trie structures and adds support for Block Access Lists (BAL) in the Amsterdam fork. The changes include:
- Parallel batch update methods for tries (Merkle Patricia, Secure, Verkle, and Transition tries)
- Configuration support for BAL feature enablement
- Test fixtures and comprehensive test coverage for BAL functionality
- Minor fixes to comment formatting and API signatures
Reviewed Changes
Copilot reviewed 111 out of 140 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| trie/trie.go | Adds concurrent batch update method with parallelism optimization |
| trie/secure_trie.go | Implements batch update methods for account and storage updates |
| trie/verkle.go | Adds batch update wrappers for Verkle trie operations |
| trie/transition.go | New transition trie implementation with batch update stubs |
| trie/dummy_trie.go | Adds no-op batch update methods to empty trie |
| trie/trie_test.go | Adds comprehensive batch update tests and fixes comment formatting |
| tests/state_test_util.go | Updates SetCode call to include tracing parameter |
| tests/init.go | Adds Amsterdam fork configuration |
| tests/gen_btheader.go | Adds BlockAccessListHash field to block header |
| tests/fixtures-amsterdam-bal/* | Comprehensive test fixtures for BAL validation |
| params/config.go | Adds EnableBAL flag and BAL-related helper methods |
| node/config.go | Removes EnableBAL from node config (moved to chain config) |
| miner/miner.go | Fixes type assertion for pending state |
| internal/web3ext/web3ext.go | Adds debug RPC methods for BAL inspection |
| internal/ethapi/simulate.go | Updates system contract processing signatures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fynnss
force-pushed
the
feature/bal_with_post_state_no_consensus
branch
from
4999094 to
2fce784
Compare
fynnss
force-pushed
the
feature/bal_with_post_state_no_consensus
branch
2 times, most recently
from
e3dc9f4 to
bcf6d5f
Compare
buddh0
reviewed
Dec 2, 2025
miner/worker.go
Outdated
Contributor
There was a problem hiding this comment.
?? result/core/types/block.go./core/types/block.go
buddh0
reviewed
Dec 2, 2025
miner/worker.go
Outdated
Contributor
Author
There was a problem hiding this comment.
It's useless. I'll remove it.
buddh0
reviewed
Dec 2, 2025
| defer release() | ||
|
|
||
| // upgrade built-in system contract before normal txs if Feynman is not enabled | ||
| systemcontracts.TryUpdateBuildInSystemContract(api.backend.ChainConfig(), block.Number(), parent.Time(), block.Time(), statedb, true) |
Contributor
There was a problem hiding this comment.
why change this file? it will break these apis
Contributor
Author
There was a problem hiding this comment.
merge from upstream. I'll restore these files.
fynnss
changed the title
fynnss
force-pushed
the
feature/bal_with_post_state_no_consensus
branch
from
79b5159 to
602e68f
Compare
buddh0
reviewed
Dec 3, 2025
core/vm/jump_table_export.go
Outdated
Contributor
There was a problem hiding this comment.
this file is not right for bsc, skip many hardforks
also not used, so remove it is bettor
buddh0
reviewed
Dec 3, 2025
core/types/block.go
Outdated
Contributor
There was a problem hiding this comment.
'fmt.Println("error here")'
need to be improved
buddh0
reviewed
Dec 3, 2025
core/types.go
Outdated
Contributor
There was a problem hiding this comment.
define validateState, but never used
Contributor
Author
There was a problem hiding this comment.
It was originally used to control whether or not root hash calculations were performed inside the validatorstate, as they were already processed in calcAndVerifyRoot in the parallel state processor.
Contributor
Author
There was a problem hiding this comment.
But anyway, I'll remove it.
fynnss
force-pushed
the
feature/bal_with_post_state_no_consensus
branch
3 times, most recently
from
9991315 to
4dbddfd
Compare
fynnss
force-pushed
the
feature/bal_with_post_state_no_consensus
branch
3 times, most recently
from
7bf5637 to
0d28ae1
Compare
fynnss
force-pushed
the
feature/bal_with_post_state_no_consensus
branch
from
0d28ae1 to
a8bdbb0
Compare
buddh0
previously approved these changes
Dec 9, 2025
MatusKysel
reviewed
Dec 12, 2025
MatusKysel
reviewed
Dec 12, 2025
zzzckck
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr impl no consensus based Block-Access-List(EIP-7928).
Cherry-pick from ethereum/go-ethereum#32263 and using the non-consensus method in BEP-592 #3374
Rationale
Deviations from EIP-7928:
Example
Changes
Notable changes:
*